search

PrisonTeam / Prison

The home of the Prison project, a Minecraft plugin to provide mining and ranking gameplay experience.
https://www.spigotmc.org/resources/prison.1223/
Other
131 stars 48 forks source link

Added romanian locale #230

Closed Oreoezi closed 2 years ago

Oreoezi commented 2 years ago

This is my first commit on windows. Yes, I did take the time to translate the comments, I am not even sure if I should've.

rbluer commented 2 years ago

Thanks for the contribution. It really does not matter if you translated the comments or not, since it shouldn't impact anything.

But one thing I need you to do, is could you change the pull request to be pulled in to the bleeding branch instead of master? Master is only used for tested and published releases. So by pulling it in to bleeding it can be included with the current alpha releases so it can be tested.

I'm also thinking there is a class in the language handling code that should be updated to better handle this addition. It would allow the mapping of secondary languages to be used if a message setting is missing.

That said, what would be the next reasonable language to use as the fallback language, if any? English will always be the last go to language.

Oreoezi commented 2 years ago

Thanks for the contribution. It really does not matter if you translated the comments or not, since it shouldn't impact anything.

But one thing I need you to do, is could you change the pull request to be pulled in to the bleeding branch instead of master? Master is only used for tested and published releases. So by pulling it in to bleeding it can be included with the current alpha releases so it can be tested.

I'm also thinking there is a class in the language handling code that should be updated to better handle this addition. It would allow the mapping of secondary languages to be used if a message setting is missing.

That said, what would be the next reasonable language to use as the fallback language, if any? English will always be the last go to language.

sorry about that ill make a new PR asap.