search

PrisonTeam / Prison

The home of the Prison project, a Minecraft plugin to provide mining and ranking gameplay experience.
https://www.spigotmc.org/resources/prison.1223/
Other
131 stars 48 forks source link

Update SpigotPlayer.java #254

Closed DinoFengz closed 9 months ago

DinoFengz commented 9 months ago

Fix java.lang.NullPointerException: Cannot read field "isAutoSellPerUserToggleable" because the return value of "tech.mcprison.prison.spigot.sellall.SellAllUtil.get()" is null

when sellall modules is disabled.

rbluer commented 9 months ago

Thanks for bringing this to my attention.

I noticed there were other similar issues that needed to be changed too, so I went ahead and corrected those other classes too.

Thanks also for opening a PR too... If you would like to contribute more in the future, please DM me in discord, or on our support discord server. I'm wanting to take a more active role in code review prior to pulling anything in, which would help to ensure certain styles are more consistent and that changes won't lead to other issues.

You know what? I think I just screwed up. I'm sorry about that. I should have pulled in your change and then made modifications to that instead of the original code. :( I don't want to discourage you from providing future contributions, so please DM me the next time and I'll try better to make sure it's included.