PritamSarbajna / tourism-website

ADVENTURE - A simple website of a tourism agency for tourists.
https://simple-tourism-organization.netlify.app/
MIT License
159 stars 112 forks source link

[BUG] : In hover, covering content #21

Closed PritamSarbajna closed 2 years ago

PritamSarbajna commented 2 years ago

When I'm hovering it's transforming and covering the content as shown below.

Screenshot (203)

Suggestive changes :

Either change the transform scale or move the content little left.

hurricanejay commented 2 years ago

Hi @PritamSarbajna - I'd like to tackle this if you don't mind.

PritamSarbajna commented 2 years ago

Hey @hurricanejay sure go for it. should I assign you ?

hurricanejay commented 2 years ago

@PritamSarbajna yes please assign me! thanks.

Brainiac-M commented 2 years ago

I'm interested in working on this issue

prakhartiwari0 commented 2 years ago

Hey, I can help with this one too. Can you assign me this?

PritamSarbajna commented 2 years ago

Hey @prakhartiwari2507 and @Brainiac-M you both can collaborate with @hurricanejay for this issue and try to resolve it

hurricanejay commented 2 years ago

Hey @prakhartiwari2507 and @Brainiac-M, I just did a PR for this https://github.com/PritamSarbajna/tourism-website/compare/main...hurricanejay:jay_bugfix?expand=1

Screen Shot 2022-08-15 at 2 51 45 PM

I did notice that on large screens the images look like this with the image attached around 1688px. I assume he still wants it to stack as 2x2 @PritamSarbajna do you want them to address this?

P.S. - this is my first open source contribution. LMK if I'm following the correct steps. Thanks!

Brainiac-M commented 2 years ago

This is my first contribution too @hurricanejay.

prakhartiwari0 commented 2 years ago

Hey @hurricanejay, I don't know if @PritamSarbajna wanted to change the layout of the images. I have made the required changes without changing the layout. Let him tell is that what he wanted or not.

PritamSarbajna commented 2 years ago

Hey @prakhartiwari2507 and @Brainiac-M, I just did a PR for this https://github.com/PritamSarbajna/tourism-website/compare/main...hurricanejay:jay_bugfix?expand=1

Screen Shot 2022-08-15 at 2 51 45 PM

I did notice that on large screens the images look like this with the image attached around 1688px. I assume he still wants it to stack as 2x2 @PritamSarbajna do you want them to address this?

P.S. - this is my first open source contribution. LMK if I'm following the correct steps. Thanks!

Hey @hurricanejay you haven't made a PR have you ? also I don't wanted to change the layout welcome to opensource contribution both of you you can find various beginner friendly issue in this repo feel free to resolve them.

PritamSarbajna commented 2 years ago

Hey @prakhartiwari2507 this was assigned to @hurricanejay actually I'm approving your PR but don't do this frequently. Thank you 🙌

prakhartiwari0 commented 2 years ago

Oh, @PritamSarbajna and @hurricanejay I am sorry, you already I am not much experienced, this is my starting. I thought if I could solve the issue then there was no problem. I will take care of this in the future, and talk with the assignee to collaboratively solve the issue.