Closed PritamSarbajna closed 2 years ago
Hi @PritamSarbajna - I'd like to tackle this if you don't mind.
Hey @hurricanejay sure go for it. should I assign you ?
@PritamSarbajna yes please assign me! thanks.
I'm interested in working on this issue
Hey, I can help with this one too. Can you assign me this?
Hey @prakhartiwari2507 and @Brainiac-M you both can collaborate with @hurricanejay for this issue and try to resolve it
Hey @prakhartiwari2507 and @Brainiac-M, I just did a PR for this https://github.com/PritamSarbajna/tourism-website/compare/main...hurricanejay:jay_bugfix?expand=1
I did notice that on large screens the images look like this with the image attached around 1688px. I assume he still wants it to stack as 2x2 @PritamSarbajna do you want them to address this?
P.S. - this is my first open source contribution. LMK if I'm following the correct steps. Thanks!
This is my first contribution too @hurricanejay.
Hey @hurricanejay, I don't know if @PritamSarbajna wanted to change the layout of the images. I have made the required changes without changing the layout. Let him tell is that what he wanted or not.
Hey @prakhartiwari2507 and @Brainiac-M, I just did a PR for this https://github.com/PritamSarbajna/tourism-website/compare/main...hurricanejay:jay_bugfix?expand=1
I did notice that on large screens the images look like this with the image attached around 1688px. I assume he still wants it to stack as 2x2 @PritamSarbajna do you want them to address this?
P.S. - this is my first open source contribution. LMK if I'm following the correct steps. Thanks!
Hey @hurricanejay you haven't made a PR have you ? also I don't wanted to change the layout welcome to opensource contribution both of you you can find various beginner friendly issue in this repo feel free to resolve them.
Hey @prakhartiwari2507 this was assigned to @hurricanejay actually I'm approving your PR but don't do this frequently. Thank you 🙌
Oh, @PritamSarbajna and @hurricanejay I am sorry, you already I am not much experienced, this is my starting. I thought if I could solve the issue then there was no problem. I will take care of this in the future, and talk with the assignee to collaboratively solve the issue.
When I'm hovering it's transforming and covering the content as shown below.
Suggestive changes :
Either change the transform scale or move the content little left.