PritamSarbajna / tourism-website

ADVENTURE - A simple website of a tourism agency for tourists.
https://simple-tourism-organization.netlify.app/
MIT License
161 stars 117 forks source link

[FEATURE] : Light/Dark theme toggle #58

Closed anchalsinghrajput closed 2 years ago

anchalsinghrajput commented 2 years ago

You can add a theme toggle button in your website, which will change your website to go from dark mode to light and vice versa. Have a look on below one. (https://codepen.io/PaulinaSurazynska/pen/bGVpBOb)

PritamSarbajna commented 2 years ago

@anchalsinghrajput that'd be great but for that we really need to discuss about your color proposal for the website.

discussion -> #60

NOTE : If you would like to work on it, you have to mention, then I'll assign you

PritamSarbajna commented 2 years ago

Hey @Abhishekcuso there is a few issues in the issues section if you think you can work on it or fix it I'd be love to assign you on that. Also, you can see the website and if you can anyhow improve the website, you may mention and I'll assign you.

PritamSarbajna commented 2 years ago

Hey @Abhishekcuso this isn't making any sense until you make a PR sorry also this issue isn't assigned to you :")

PritamSarbajna commented 2 years ago

since you are working on react , its hard for me to run this on npm. So id suggest you to try out the above code . also may I know about the thing you talked about color preference

Hi @Abhishekcuso This project doesn't contain react. It's a pure html, css, javascript website

PritamSarbajna commented 2 years ago

sorry for that, so wont you be able to assign this task to me?

Yeah I can assign but I have already assigned you on two issues please do finish them first and let me know. I'd love to assign you on this 🙌

PritamSarbajna commented 2 years ago

Yeah on the issues you want to work on also you have replied thank you there

PritamSarbajna commented 2 years ago

oh that's someone else and not me , it's sayali while I'm Abhishek . You've assigned the task to her

Okay that's a mistake I got there apologies

Iamslok commented 2 years ago

@PritamSarbajna I would like to work on this issue, Can you assign me.

PritamSarbajna commented 2 years ago

yeah sure @Iamslok here you go

suraj1609 commented 2 years ago

heyy, i am suraj kanse,i would like to contribute to this issue.can you assign me this work if you dont mind.

PritamSarbajna commented 2 years ago

Hey @suraj1609 sorry this issue is already assigned to @Iamslok. Make sure to check other issues 🙌

suraj1609 commented 2 years ago

Ohk

On Mon, 19 Sept 2022, 9:57 pm Pritam Sarbajna, @.***> wrote:

Hey @suraj1609 https://github.com/suraj1609 sorry this issue is already assigned to @Iamslok https://github.com/Iamslok. Make sure to check other issues 🙌

— Reply to this email directly, view it on GitHub https://github.com/PritamSarbajna/tourism-website/issues/58#issuecomment-1251252876, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGGH526R6VX5UDCNIVLAY3V7CH77ANCNFSM6AAAAAAQHMP4JU . You are receiving this because you were mentioned.Message ID: @.***>

Iamslok commented 2 years ago
image

@PritamSarbajna when I am trying to push the code it's showing like the above image, can you please help me with that

PritamSarbajna commented 2 years ago

Do this if it helps git pull origin Light/dark_Toggle then git push

Iamslok commented 2 years ago
image

@PritamSarbajna Denied request

PritamSarbajna commented 2 years ago

Try it : git push origin HEAD

Iamslok commented 2 years ago
image

It's done right, how can I create a pull request?

PritamSarbajna commented 2 years ago

Just go to you forked repo you can now see a option to make a pull request

Iamslok commented 2 years ago

Yeah @PritamSarbajna it's done, thank you