Privacy-Managers / Privacy-Manager

Privacy Manager - Chrome extension
GNU General Public License v3.0
28 stars 6 forks source link

Cookies list is not updated after deleting a cookie #83

Closed alexdevero closed 4 years ago

alexdevero commented 4 years ago

The list of cookies is not updated after deleting some cookie on the list. It is updated only if I click on the cookie to see all cookies for that domain and only then I remove the domain/cookie.

In earlier version, cookies list was update every time cookie has been deleted. Now, it is necessary to close the extension pop-up and open it again to "refresh" the list.

Steps to reproduce: 1) Visit some website to store a new cookie 2) Open the extension pop-up and click the button to remove the cookie. 3) Observe that the list will not refresh and the cookies stays on the list, even though it no longer exists.

Browser: Vivaldi 2.10.1745.26 (built on Chrome 79.0.3945.118)

Výstřižek

Manvel commented 4 years ago

@alexdevero Thanks for reporting the issue, I can confirm that the cookies for domain are not deleted unless list item is expanded.

Lately Privacy Manager went through big rewrite, it's a shame that the automation tests didn't fetch the case and I have missed that.

I'll have a closer look into what is causing the issue and come back to you with more details.

alexdevero commented 4 years ago

Thank you @Manvel.

Manvel commented 4 years ago

@alexdevero the issue was caused by a blocking case, which tried to ensure that item has subitems(is expanded) before removing from the UI and automated tests which suppose to fetch that error, were running on the expanded item.

Thanks again for noticing the issue, the release is out and available in the Chrome Web Store.

alexdevero commented 4 years ago

Can confirm that the fix works.