search

PrivacyDevel / nitter

Alternative Twitter front-end
https://nitter.net
GNU Affero General Public License v3.0
151 stars 29 forks source link

with_replies also fetching people who replied to tweets #8

Closed roryyamm closed 1 year ago

roryyamm commented 1 year ago

Not sure if this is specific to this fork, or Nitter in general, but it only occurs when on the privacydev.net instance.

When using the /with_replies page, sometimes people who replied to the user in question get presented alongside that user's own replies, retweets, and normal tweets. This also shows up in the RSS feeds of said page, leading to an RSS feed full of random people. This is not desirable.

PrivacyDevel commented 1 year ago

This may have been introduced in graphql-missing-threads-bug-fix / 1634ffdf43c1d9351b7d02103061baa8fa247fd6. ping https://github.com/zedeus/nitter/pull/885

zedeus commented 1 year ago

Found an example here: image

image

image

image

It's probably caused by the automatic threading Nitter performs, not sure how it should work here.

roryyamm commented 1 year ago

@zedeus would it be possible to disable threading for RSS feeds?

pin-grid-array commented 1 year ago

@zedeus would it be possible to disable threading for RSS feeds?

This is the solution.

I noticed that these two instances are not affected by the bug described by roryyamm: https://nitter.caioalonso.com/MarkHamill/with_replies/rss https://nitter.privacytools.io/MarkHamill/with_replies/rss

What do these two instances have in common? They do not show threading in with_replies, except when the user replies to themselves.

I made a small list of instances that are affected by the bug in this post. (The instance nitter.privacydev.net is one of several affected.) What do all of those instances have in common? They all show threading in with_replies.

So, disabling threading appears to be the correct solution.

In that same post, I also made a small list of instances that are not affected by the bug but whose with_replies/rss feed is completely broken by not showing any replies at all. At first, I thought it was related to the bug, but after reading this thread and learning that the problem is caused by threading, maybe it is not related after all.

zedeus commented 1 year ago

It's broken because they don't use the new-ish GraphQL API that remotely up-to-date Nitter instances use. Disabling threading is not a solution, it's just a temporary workaround. A fix would be to adjust the threading to handle this new Twitter behavior.

PrivacyDevel commented 1 year ago

This issue seems to have been solved: https://github.com/zedeus/nitter/issues/893#issuecomment-1647108842