search

PrivacyLx / privacylx-issue-tracker

PrivacyLx Issue Tracker repository
0 stars 0 forks source link

Remove twitter embeddings #42

Closed francisco-core closed 5 years ago

francisco-core commented 5 years ago

Sadly hugo (our website framework) is not privacy-friendly by default. So apparently it was embedding twitter. If we go to lenghts tor even remove functional js we should also remove his

francisco-core commented 5 years ago

Crossposted from #43. @anadahz said:

Currently the website is making calls to Twitter's API:

$ hugo server -D .
Building sites … ERROR 2019/08/29 14:48:28 Failed to get json resource https://api.twitter.com/1/statuses/oembed.json?id=781493632293605376&dnt=false with error message Get https://api.twitter.com/1/statuses/oembed.json?id=781493632293605376&dnt=false: dial tcp: lookup api.twitter.com on [::1]:53: read udp [::1]:58289->[::1]:53: read: connection refused
ERROR 2019/08/29 14:48:28 error processing shortcode "_internal/shortcodes/tweet.html" for page "events/qubes-intro.en.md": template: _internal/shortcodes/tweet.html:7:13: executing "_internal/shortcodes/tweet.html" at <getJSON $url>: error calling getJSON: Get https://api.twitter.com/1/statuses/oembed.json?id=781493632293605376&dnt=false: dial tcp: lookup api.twitter.com on [::1]:53: read udp [::1]:58289->[::1]:53: read: connection refused
ERROR 2019/08/29 14:48:28 Failed to get json resource https://api.twitter.com/1/statuses/oembed.json?id=781493632293605376&dnt=false with error message Get https://api.twitter.com/1/statuses/oembed.json?id=781493632293605376&dnt=false: dial tcp: lookup api.twitter.com on [::1]:53: read udp [::1]:51424->[::1]:53: read: connection refused
ERROR 2019/08/29 14:48:28 error processing shortcode "_internal/shortcodes/tweet.html" for page "events/qubes-intro.pt.md": template: _internal/shortcodes/tweet.html:7:13: executing "_internal/shortcodes/tweet.html" at <getJSON $url>: error calling getJSON: Get https://api.twitter.com/1/statuses/oembed.json?id=781493632293605376&dnt=false: dial tcp: lookup api.twitter.com on [::1]:53: read udp [::1]:51424->[::1]:53: read: connection refused
Total in 1448 ms
Error: Error building site: logged 2 error(s)

We should make sure there are no calls to Twitter AFAIK there is no need for it.