search

PrivacyLx / privacylx-issue-tracker

PrivacyLx Issue Tracker repository
0 stars 0 forks source link

Remove Third-party scripts from website #9

Closed francisco-core closed 5 years ago

francisco-core commented 5 years ago

on the file website/themes/hugo-bootstrap/layouts/_default/baseof.html some third-party scripts are called. We should host our own copy of these

kcg295 commented 5 years ago

Are the scripts 100% necessary? Ideally we should be compatable with browsers that choose to block all JS.

anadahz commented 5 years ago

According to the comment in baseof.html seems there are optional.

A safe move would be to test that the website is working fine without them.

francisco-core commented 5 years ago

I tested removing them before. Most of the website works fine. It's just that on mobile the navigation bar does not drop down. We could host those locally I guess. Ideally no script would be needed. But that would need to rethink the header of the page and maybe do one of those dynamic things with bootstrap "@media", I think to adapt to the screen-size. But I'm not too familiar with that.

anadahz commented 5 years ago

It seems that it's possible to use bootstrap without jquery.

francisco-core commented 5 years ago

The only problem left I think is the hamburger menu (for mobile versions). It doesn't seem to work without js. managed to remove popper.js which apparently was useless. Someone was able to make a css-only version of the hamburger menu here: https://viralpatel.net/blogs/bootstrap-navbar-menu-without-javascript/. I was playing around with it but didn't manage to put it to work in the time I had available

francisco-core commented 5 years ago

closed by "added header for mobile & removed scripts #8"