Open mattkrau opened 5 years ago
Thank you for your pull request. We discussed most of it already in person, but for the record here are the most important points:
Regarding SRI
Page.failed_request_log
).scripts_disabled
context manager to avoid changes to the DOM while searching.Regarding the generator tag
meta[name="generator" i]
. This will return all nodes you are interested inscripts_disabled
context manager to avoid changes to the DOM while searching.Regarding additional serverleaks
_match_package_file
uses "binary or" in the loop instead of "logical or". You could replace this loop with the any
function together with an generator expression, i.e., return any(target in content for target in targets)
. Use the beauty of Python :-)
As talked about in the weekly meeting, rebased to master:
Adds following functionalities: