Open ww7 opened 3 months ago
I retested this and it does have the expected default paragraph spacing between the top and bottom, which I feel is adequate and looks nice (to me). I would therefore suggest that you solve this via a custom template.
Do other maintainers feel differently about this? Otherwise I'll close this as wont-fix.
For compare, added padding 2rem;
and background-color
the same as in header.
Okay, you should have attached such an image directly (for such a visual issue9. IMHO, just looking at the images, the right one looks better to me personally, indeed?
I guess the right one is your proposed solution? If so, it's technically of course more about the spacing to the left and right.. well... anyway. If @elrido agrees, and this is fine for you, it would be great if you could open a PR to get this merged @ww7. Note, please also test (and screenshot) it in mobile screens/responsive test tools etc. to make sure it also works on smaller screens.
Edit: Also it would be useful to see whether the same style should be applied to other formats, like text-only. (Source code likely not, because it has it's own style already.)
So, essentially you wanted to have the "card" CSS class get applied to plain text and markdown content, same as it currently is for the source code? https://github.com/PrivateBin/PrivateBin/blob/e865bec9c38bda15ee59d0b29e4463abc50b71ab/tpl/bootstrap5.php#L429-L432
As stated, I do not like this, visually, and would prefer to not display these two content types differently, but yes, if a PR is raised and other maintainers prefer that distinct style as well, I won't stand in the way. These are just personal differences in taste.
You can see a difference between presentation of "Plain Text", "Source Code" and "Markdown, where first two showing content with background and padding.
Personally I simply edited common.css
#plaintext {
padding: 2rem;
background-color: rgb(248, 249, 250)!important;
}
article {
margin-bottom: 2rem;
}
This is not a solution for PR for sure.
The problem
Makrdown text merges with the footer and top menu
The solution
Create some spacing (padding) on top and bottom of paste section, add some visual separation with lines or background color.