PrivateStorageio / ZKAPAuthorizer

a Tahoe-LAFS storage-system plugin which authorizes storage operations based on privacy-respecting tokens
10 stars 7 forks source link

Some tests in `test_client_resource.py` run asynchronous operations without waiting for them to complete #422

Closed exarkun closed 2 years ago

exarkun commented 2 years ago

These tests use create_pumper from Autobahn which returns an object with a stop method which returns a Deferred. These tests uses testtools.TestCase.addCleanup to call the pumper stop method. However, testtools.TestCase.addCleanup doesn't wait on Deferred return values unless run_tests_with is set to an AsynchronousDeferredRunTest instance - which these tests do not do.