search

PrivateStorageio / ZKAPAuthorizer

a Tahoe-LAFS storage-system plugin which authorizes storage operations based on privacy-respecting tokens
10 stars 7 forks source link

Switch ITahoeClient to use tahoe-capabilities instead of str and home-grown functionality #430

Closed exarkun closed 2 years ago

exarkun commented 2 years ago

Fixes #427

codecov[bot] commented 2 years ago

Codecov Report

Merging #430 (f82b3c4) into main (5db6968) will increase coverage by 0.27%. The diff coverage is 98.29%.

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   95.01%   95.29%   +0.27%     
==========================================
  Files          62       62              
  Lines        8026     8011      -15     
  Branches     1036     1035       -1     
==========================================
+ Hits         7626     7634       +8     
+ Misses        294      274      -20     
+ Partials      106      103       -3
Impacted Files Coverage Δ
src/_zkapauthorizer/_types.py 85.71% <ø> (-0.96%) :arrow_down:
src/_zkapauthorizer/resource.py 91.75% <ø> (-0.03%) :arrow_down:
src/_zkapauthorizer/tahoe.py 92.81% <95.74%> (+0.50%) :arrow_up:
src/_zkapauthorizer/recover.py 94.92% <100.00%> (ø)
src/_zkapauthorizer/replicate.py 95.18% <100.00%> (ø)
src/_zkapauthorizer/tests/__init__.py 60.00% <100.00%> (ø)
src/_zkapauthorizer/tests/common.py 98.34% <100.00%> (+2.47%) :arrow_up:
src/_zkapauthorizer/tests/test_client_resource.py 98.09% <100.00%> (-0.02%) :arrow_down:
src/_zkapauthorizer/tests/test_plugin.py 99.71% <100.00%> (-0.01%) :arrow_down:
src/_zkapauthorizer/tests/test_recover.py 99.10% <100.00%> (-0.01%) :arrow_down:
... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

hacklschorsch commented 2 years ago

Belated review: I think his is a lovely patch.