search

PriyaGhosal / SkillWise

This Repository is now officially part of Hacktoberfest 2024 !!!
https://skillwise.netlify.app/
Other
124 stars 388 forks source link

Issues in data-science.html #94

Closed anshumangahlot closed 2 weeks ago

anshumangahlot commented 1 month ago

Issues :

  1. Accessibility Compliance: The alt attributes for images lack adequate descriptions for assistive technologies. For example, “Introduction to Data Science icon” should be replaced with a more meaningful description, such as “Icon representing introductory data science concepts.”
  2. Missing Hyperlink Targets: All anchor tags use href="#", which results in null links. Replace these with valid URLs or use href="javascript:void(0);" as a temporary placeholder. Additionally, ensure that aria-label values are specific for improved screen reader accessibility.
  3. Image Size Inconsistencies: The dimensions of the images are inconsistent (e.g., image1.jpg is 300x100 while image5.png is 250x100). Standardize image dimensions or handle the sizing via CSS to avoid layout misalignments.
  4. Potential Broken Image Paths: Verify that the image paths in ./assets/images/data-science/ are correct. Images will not render if the file paths are incorrect or files are missing.
  5. Inline Style Usage: Inline styles such as style="margin-bottom: 30px;" and style="margin-top: 20px;" should be moved to external CSS to adhere to best practices for separation of concerns and maintainable code.
  6. Language Attribute Specification: While lang="en" is acceptable, consider using lang="en-US" for better regional specificity, particularly when targeting American English.
  7. SEO Optimization: Improve the page’s for better search relevance, and add a meta description tag to enhance SEO performance and search engine visibility.</li> </ol> <p>I am submitting a pull request which fixes most of the issues .</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/PriyaGhosal"><img src="https://avatars.githubusercontent.com/u/162816363?v=4" />PriyaGhosal</a> commented <strong> 1 month ago</strong> </div> <div class="markdown-body"> <p>Thanks for creating the issue in <em>SkillWise</em>!!! The issue has been assigned to you.</p> <p>Before you start working on your PR, please make sure to:</p> <ul> <li>⭐ Star the repository if you haven't already.</li> <li>Pull the latest changes to avoid any merge conflicts.</li> <li>Attach <em>before & after screenshots</em> in your PR for clarity.</li> <li>Include the <em>issue number</em> in your PR description for better tracking.</li> </ul> <p>I'm excited to see your contribution as part of <em>Hacktoberfest 2024</em>! 🎉<br /> Don't forget to follow me on GitHub for more updates.</p> <p>Happy open-source contributing! 🚀</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>