search

Priyaaa1 / StartConnect-Hub

https://startconnect-hub.netlify.app/
MIT License
73 stars 144 forks source link

Fixes #340 Corrected the disfucntional google login button #503

Closed ritankarsaha closed 1 week ago

ritankarsaha commented 1 week ago

This PR fixes the issue #340.

EXPLANATION:-

The Google Login Button now works properly enabling the user to successfully login and signin. This basically uses @react-oauth/google component to ensure that the login/signin activities are carried out smoothly without any hindrance. The control has been shifted from json web tokens to this module ensuring a more smooth and authentic login using google OAuth client.

PROOF OF WORK:-

Screenshot 2024-06-19 at 12 36 26 AM

This Screenshot shows that i can now easily login using any of my google ids, without any hindrance and it removes the problem of displaying only a blank page.

REQUISITES:-

Here i have created a google oauth client and registered it as a web application thereby generating my oauth client id and password. Thereby i used that google client id to display the login feature. You can similarly create a new Client id in the Google API console registering this application as a web application and input your generated google client id here at line 49 instead of YOUR_CLIENT_ID.

Screenshot 2024-06-19 at 12 50 13 AM

This screenshot shows the area where you need to change your client id.

Thank You.

netlify[bot] commented 1 week ago

Deploy Preview for startconnect-hub ready!

Name Link
Latest commit 1e327f03cf2d0611954c3596f07195a5953c3043
Latest deploy log https://app.netlify.com/sites/startconnect-hub/deploys/6671df170eedf80008dc7f84
Deploy Preview https://deploy-preview-503--startconnect-hub.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ritankarsaha commented 1 week ago

@Priyaaa1 I have fixed the issue #340 and opened a PR #503 for the same. Thank You.

Priyaaa1 commented 1 week ago

image

@ritankarsaha still not working

ritankarsaha commented 1 week ago

@Priyaaa1 You need to add your own Google client id in the place shown in the second screenshot, after creating it from the Google API console and registering the app as a web application.

I have given the steps in my PR. In the screenshot, I see that the ID is showing "YOUR_GOOGLE_CLIENt_ID. And you haven't yet modified it. After creating the I'd from the API console and putting it there in place of that, it will work without any problems. Please refer to the steps in the requisites of my PR #503. Please let me know if you face any more issues regarding creating the Google OAuth Client ID. Thank You.

Priyaaa1 commented 1 week ago

@ritankarsaha kindly resolve conflicts, so that I can merge

ritankarsaha commented 1 week ago

@ritankarsaha kindly resolve conflicts, so that I can merge

I had already deleted the folder from my PC. So i am now unable to revert back to those changes the earlier commits using git reset --hard. However i have opened a new PR #511 with the same changes resolving the merge conflicts. Kindly accept and merge that PR #511 and follow the OAuth client id creation process as defined in this PR #503 and you can close this PR later. Thank You for understanding.