search

Priyansh-Kedia / OpenGraphParser

Open Graph Parser for Android
MIT License
85 stars 15 forks source link

upgrade jsoup version to 1.13.1 #18

Closed ashishcors closed 1 year ago

ashishcors commented 1 year ago

Issue: Was getting crash while parsing url on release builds (with minifyEnabled = true). Was unable to pull logs due to it being minified release build. Upgrading the version solved the issue.

ashishcors commented 1 year ago

Issue #19

Priyansh-Kedia commented 1 year ago

Hello @jasperx21 You must be using proguard in your app.

Including -keep public class org.jsoup.** { public *; } in your proguard-rules.pro file, and the app should not crash without changing the jsoup version.

Can you please check this and confirm. Thanks

ashishcors commented 1 year ago

Including -keep public class org.jsoup.** { public *; } in your proguard-rules.pro file, and the app should not crash without changing the jsoup version.

Yup, this works too. In that case can we please add this as part of readme?

Priyansh-Kedia commented 1 year ago

Including -keep public class org.jsoup.** { public *; } in your proguard-rules.pro file, and the app should not crash without changing the jsoup version.

Yup, this works too. In that case can we please add this as part of readme?

Yes, sorry I had missed that. I have added this to the README. You can check it now.

Priyansh-Kedia commented 1 year ago

Thank you for your contribution @jasperx21.

Closing this PR now.