search

Priyansh-Kedia / OpenGraphParser

Open Graph Parser for Android
MIT License
85 stars 15 forks source link

Is the null check normal? #9

Closed mazeloper closed 2 years ago

mazeloper commented 2 years ago

First of all, I'm not good at English, so please forgive me.

When checking for title and description null, is there any reason to use openGraphResult!!.title.equals("null") ? It's actually null, but it's not a string, so it's not a normal null check.

library : openGraphResult!!.title?.isEmpty() == true || openGraphResult!!.title.equals("null")

I think this is it openGraphResult!!.title?.isNullOrEmpty() == true || openGraphResult!!.title.equals("null")

It's always in good use. please check.

Thank you 😀

Priyansh-Kedia commented 2 years ago

@sta-con can you link this issue to the PR you created?

mazeloper commented 2 years ago

@Priyansh-Kedia
Sorry. I'm not sure what you mean

I'm not very good at using Git 🙏