search

Pro / dkim-exchange

DKIM Signing Agent for Microsoft Exchange Server
Other
408 stars 143 forks source link

Add support for Exchange 2016 CU22 and Exchange 2019 CU11 #346

Closed MisterSausage closed 3 years ago

MisterSausage commented 3 years ago

Changes included in this PR:

jaumesnts commented 3 years ago

Any news about this commit? Anyone has tried to install newer CU's with current version of dkim-exchange installed?

FXEGIT commented 3 years ago

Hi, Can I safely update my Exchange 2019 CU10 to CU11 with DKIM signer enabled ? Thank you.

MisterSausage commented 3 years ago

@FXEGIT Yes, it'll be fine.

FXEGIT commented 3 years ago

OK, thank you for your quick answer @MisterSausage !

FXEGIT commented 3 years ago

One more question : OK with 3.3.2 or should I update to 3.3.3 DKIM signer version ?

MisterSausage commented 3 years ago

@FXEGIT Ideally, update to the version in this pull request - 3.3.4, which has specific support for Exchange 2019 CU11. In practice, both 3.3.2 and 3.3.3 will work OK, but they'll complain.

FXEGIT commented 3 years ago

OK. Shame on me but I don't now how to update to the version in the pull request as it is not listed in Exchange-DKIM GUI loader... 3.3.3 is the latest version shown in prerelease state.

MisterSausage commented 3 years ago

@FXEGIT There's nothing I can do about that, I'm afraid. As you can see (because you're commenting on it right now!), I've submitted a pull request for the new version, but unfortunately I'm not a maintainer of this project so I can't do anything further. To proceed, one of the maintainers needs to assess and merge this pull request and create a release, and to date nothing's happened. The previous version (3.3.3) has been stranded in pre-release status too.

FXEGIT commented 3 years ago

Damned, not really reassuring. Is it meaning this project is not actively maintained anymore ?

DJBenson commented 3 years ago

Damned, not really reassuring. Is it meaning this project is not actively maintained anymore ?

Nope, it means that I’ve had other things to do in the real world. I will merge and build the pull request in the next 24 hours. Thanks for your patience.

MisterSausage commented 3 years ago

@DJBenson Thanks

DJBenson commented 3 years ago

@DJBenson Thanks

No, thank you and sorry for the delay merging your pull request.

FXEGIT commented 3 years ago

Sorry @DJBenson ! I did not want to put you under pressure ! I only ask :) Thank you for your work !

DJBenson commented 3 years ago

Sorry @DJBenson ! I did not want to put you under pressure ! I only ask :) Thank you for your work !

It’s all good, just being honest with you guys. Maintaining this project is a hobby but other stuff pays the bills 😎 I’ll get your new version out as soon as I can.

FXEGIT commented 3 years ago

No problem we understand ! Your work, even if this is your hobby, allows us to sign our outgoing emails, and this is already really cool ! Thank you again !

DJBenson commented 3 years ago

@Pro is the real brains of the outfit, I merely push new releases periodically and try and fix bugs when I find them but I’m by no means taking any credit for this fine application, I just volunteered to add releases as they come out from Microsoft as I use it myself in my self hosted Exchange setup.

MisterSausage commented 3 years ago

@DJBenson Thanks for the work you've been doing!

I note that the whole project could be simplified significantly by dropping support for unsupported versions of Exchange (<2013, unsupported CUs), and it would also resolve this quarterly problem of having to release new versions of the project for every new CU.

Are you / @Pro OK with dropping support for unsupported versions of Exchange? If so, I'm happy to sweep through and have a tidy-up. (Although I'm unlikely to get the chance for about 4-6 weeks!)

FXEGIT commented 3 years ago

OK, so let us give back to Ceasar what is in Ceasar : thanks to @Pro and @DJBenson, among others !

DJBenson commented 3 years ago

I

@DJBenson Thanks for the work you've been doing!

I note that the whole project could be simplified significantly by dropping support for unsupported versions of Exchange (<2013, unsupported CUs), and it would also resolve this quarterly problem of having to release new versions of the project for every new CU.

Are you / @Pro OK with dropping support for unsupported versions of Exchange? If so, I'm happy to sweep through and have a tidy-up. (Although I'm unlikely to get the chance for about 4-6 weeks!)

I had planned to deprecate some older versions until I saw Microsoft releasing patches going back to 2010 recently. I think @pro is happy for me to lead on this and I’d be happy to start dropping older support. Maybe I will test the waters first and ensure we aren’t going to cut adrift a lot of people. I like to think not but if people have had no reason to upgrade they may well be on really old versions.

FXEGIT commented 3 years ago

Hmm, In these times, I'm sure not updating Exchange is a wrong way... It's bad, but it's the era when we are : not up to date systems should not be online anymore...

DJBenson commented 3 years ago

Hmm, In these times, I'm sure not updating Exchange is a wrong way... It's bad, but it's the era when we are : not up to date systems should not be online anymore...

I principally agree, just want to ensure our users are (literally) with us 😊

MisterSausage commented 3 years ago

I principally agree, just want to ensure our users are (literally) with us 😊

Fair enough. I hadn't realised that Microsoft released an update for Exchange 2010 as recently as March of this year, beyond the (already extended) cut-off date of October 2020. I presume Microsoft has high-value customers stuck on that version.

Pro commented 3 years ago

@DJBenson yes, I'm happy that you take the lead on this!

Feel free to remove old versions. I would suggest the way to check the official End-of-support Date of the corresponding Version, and then remove it.

There will always be users with old versions which are not supported anymore. They can then stick with older versions of our software, or release it on their own.

stryqx commented 3 years ago

Howdy,

I'd suggest keeping the last UR for 2010 SP3, the last CU for 2013 and the latest 2 CUs for 2016 and 2019. Even though 2016 is outside of mainstream support I wouldn't be at all surprised to see Security Updates be released for the latest 2 CUs for 2016 over the next few months given the nature of the vulnerabilities fixed of late. This aligns with Microsoft's support requirements for Exchange Server with or without Hybrid configuration and would make sense for the project to follow this approach. I'd imagine in practice there would be an extra UR/CU per Exchange Server version to allow for the roll-on and roll-off of the latest UR/CU and oldest supported UR/CU across dkim-exchange releases. (i.e. new version of dkim-exchange adds support for UR/CU N+1 while keeping UR/CU N for extended support versions - 2010, 2013 and 2016 (soonish) - and keeping UR/CU N-1 for mainstream support versions - 2016 (for now) and 2019).

See the following links for reference: https://docs.microsoft.com/en-us/exchange/new-features/updates?view=exchserver-2019 https://docs.microsoft.com/en-us/exchange/new-features/updates?view=exchserver-2016 https://docs.microsoft.com/en-us/lifecycle/products/exchange-server-2019 https://docs.microsoft.com/en-us/lifecycle/products/exchange-server-2016 https://docs.microsoft.com/en-us/lifecycle/products/exchange-server-2013 https://docs.microsoft.com/en-us/lifecycle/products/exchange-server-2010 https://docs.microsoft.com/en-us/exchange/hybrid-deployment-prerequisites

On Tue, 12 Oct 2021 at 08:32, DJBenson @.***> wrote:

I

@DJBenson https://github.com/DJBenson Thanks for the work you've been doing!

I note that the whole project could be simplified significantly by dropping support for unsupported versions of Exchange (<2013, unsupported CUs), and it would also resolve this quarterly problem of having to release new versions of the project for every new CU.

Are you / @Pro https://github.com/Pro OK with dropping support for unsupported versions of Exchange? If so, I'm happy to sweep through and have a tidy-up. (Although I'm unlikely to get the chance for about 4-6 weeks!)

I had planned to deprecate some older versions until I saw Microsoft releasing patches going back to 2010 recently. I think @Pro https://github.com/Pro is happy for me to lead on this and I’d be happy to start dropping older support. Maybe I will text the waters first and ensure we aren’t going to cut adrift a lot of people. I like to think not but if people have had no reason to upgrade they may well be on really old versions.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Pro/dkim-exchange/pull/346#issuecomment-940457946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEEHYXJYB4I5CWLS7NI6JWTUGNJW5ANCNFSM5E674PGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Regards, Chris Knight

DJBenson commented 3 years ago

Code merged and build v3.3.4 pushed.

FXEGIT commented 3 years ago

Thanks a lot ! Have a good end of week !