search

ProAlgos / ProAlgos-Cpp

C++ implementations of well-known (and some rare) algorithms, while following good software development practices
MIT License
507 stars 363 forks source link

Command make all does not work #344

Closed alxmjo closed 4 years ago

alxmjo commented 4 years ago

README.md in the C++ directory gives the following directions for building:

To compile the source files, run make all.

However, when I download a fresh copy of the repo and run the command, I see the following:

alex ProAlgos-Cpp-master $ cd C++
alex C++ $ make all
make: *** No rule to make target `all'.  Stop.

Running make and make default both appear to have the desired effect. So, I think we should either update the Makefile or update README.md so that the directions are accurate.

Tagging @faheel since he originally set up CMake on the project.

faheel commented 4 years ago

Good catch! The make all command is from the time before I was using CMake. It was removed here but the documentation wasn't updated then.

faheel commented 4 years ago

Most of the the "Compiling" section in the documentation seems outdated now. It would be better to rewrite it completely, keeping in mind how the compilation process happens now using CMake and also how the Makefile helps in the process (by acting as a "helper script").

alxmjo commented 4 years ago

I've just always run make and then make test whenever I wanted to run all tests. Is there a better way?