Added code for fast fibonacci using Golden Ratio and Fast Exponentiation

ProAlgos / ProAlgos-Cpp

C++ implementations of well-known (and some rare) algorithms, while following good software development practices

MIT License

508 stars 363 forks source link

Added code for fast fibonacci using Golden Ratio and Fast Exponentiation #365

Closed vs666 closed 3 years ago

vs666 commented 4 years ago

[x] Read the contribution guidelines
[x] Added unit tests (or unit tests have already been added)
[x] Updated the Contents

alxmjo commented 4 years ago

Thanks for your contribution, @vs666. Looks like the build is failing. Please fix that and then I'll move forward with the review.

alxmjo commented 4 years ago

And for what it's worth, I'd prefer a name besides fibonacci_fast. I'm not sure what a better name would be, but I think we should be specific about the strategy used (fibonacci_golden?) rather than just that it's "fast." Perhaps there's a clue somewhere in here.

vs666 commented 4 years ago

@alxmjo build has passed, kindly review it.

alxmjo commented 4 years ago

Thank you. I'll have a look soon. In the meantime please update the Contents.

vs666 commented 4 years ago

@alxmjo Contents have been updated. You can review the PR now.

vs666 commented 4 years ago

@alxmjo any updates?

stale[bot] commented 3 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.