search

ProAlgos / ProAlgos-Cpp

C++ implementations of well-known (and some rare) algorithms, while following good software development practices
MIT License
507 stars 363 forks source link

radix sort fix #448

Closed pm100 closed 1 year ago

pm100 commented 1 year ago

radix sort had 2 bugs

first the argument order calling count_sort was wrong

second radix sort cannot sort negative values

Since I do most work on windows I also fixed the fact that it would not build on windows

closes #447 and #446

stale[bot] commented 1 year ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

faheel commented 1 year ago

Thanks for both the fixes! Can you create a new PR for the build fix on Windows? We can get it merged more quickly that way.