search

ProLoser / Github-Omnibox

Github Commands from Google Chrome Omnibox (address bar)
http://goo.gl/n5HJw
MIT License
380 stars 24 forks source link

Add onerror attribute to status images #23

Closed ProLoser closed 10 years ago

ProLoser commented 10 years ago

<img onerror="this.src='some-fixed-asset'"> would solve problems of status images for certain repos 404'ing.

I also think david-dm should be re-added. I removed it because it only covers Node, but gemnasium handles ruby and node, but now I've realized that david doesn't require you to register the package while gemnasium does.

ProLoser commented 10 years ago

I'm getting this message with the updated code:

Refused to execute inline event handler because it violates the following Content Security Policy directive: "script-src 'self' https://github.global.ssl.fastly.net https://jobs.github.com https://ssl.google-analytics.com https://collector.githubapp.com https://analytics.githubapp.com".
rodyhaddad commented 10 years ago

Wouldn't an alt attribute on the img do the trick?

ProLoser commented 10 years ago

I tried, no. But I already fixed it in the latest version. On Oct 22, 2013 7:42 PM, "rodyhaddad" notifications@github.com wrote:

Wouldn't an alt attribute on the img do the trick?

— Reply to this email directly or view it on GitHubhttps://github.com/ProLoser/Github-Omnibox/issues/23#issuecomment-26876758 .

rodyhaddad commented 10 years ago

in aa56bde31b55f2fda3a9744ee365faab535802f0, great :+1: