search

ProLoser / Github-Omnibox

Github Commands from Google Chrome Omnibox (address bar)
http://goo.gl/n5HJw
MIT License
386 stars 24 forks source link

keeps reprompting for oauth #55

Closed blaenk closed 8 years ago

blaenk commented 8 years ago

I already authorized it but every time I trigger the omnibox it shows the pop up asking if I'd like to authorize it. Could this be related to the recent name change? Perhaps it keeps checking for the previous name perhaps?

ProLoser commented 8 years ago

Yeah I need to fix this. Must have a regression around setting the authorized flag

spalger commented 8 years ago

+1

ProLoser commented 8 years ago

Yeah I know, totally planning on tackling this ASAP, been super busy. Had a film shoot this past weekend. Will do my best to address this tonight.

ProLoser commented 8 years ago

Can you guys test 1.7.2 and see if it's fixed now?

blaenk commented 8 years ago

Confirmed working, unless the following is caused by this.

By the way, if I type gh /pref it does show a suggestion for a hypothetical private repo called prefix, but pressing enter on it just goes to a repo pref. Is that intended? Is there a way that can be fixed so that, since that first suggestion is chosen, it'll go to that option when you press enter?

Otherwise the current behavior seems to be that if you type a prefix, it'll show it and highlight it as the first suggestion, but pressing enter doesn't go to it, so you still end up having to type the entire name, defeating the purpose of the suggestion no? And pressing tab actually just makes the next selection be highlighted.

blaenk commented 8 years ago

Changing the selection to any other than the first does complete the entire name, but the first option is the correct one.

ProLoser commented 8 years ago

@blaenk it's supposed to do what you wanted it to do re: pref, but can you open a new issue (this appears to be a regression)?

ProLoser commented 8 years ago

Fixed by 03033a0