ProRail-DataLab / openspoor

The openspoor package is intended to allow easy transformation between different geographical and topological systems commonly used in Dutch Railway. Its goal is to be publicly available and function as an open source package.
MIT License
7 stars 4 forks source link

Wrong interpolation in TransformerSpoortakToCoordinates.py #39

Closed Neliz closed 1 year ago

Neliz commented 2 years ago

The interpolation in the transform method in TransformerSpoortakToCoordinates.py is not valid. At the start of the geometry the lokale km is not (always) zero. So it should use the travelled distance on that geometry (difference in lokale_km from start and the point of interest). But that would still not be a correct way to do it because than it assumes that a geocode km is linear, which is not the case. We should use M-values for this.

JoostProRail commented 1 year ago

Fixed in https://github.com/ProRail-DataLab/openspoor/pull/49