ProTipHQ / ProTip

A browser extension for tipping, donations, and peer-to-peer crowd-funding
https://protip.is
GNU General Public License v3.0
96 stars 15 forks source link

Duplicate payment when clicked button twice #11

Open stevenroose opened 8 years ago

stevenroose commented 8 years ago

I configured ProTip to ask manually for payment after a week. (First of all, it did not ask me, I just happened to open the app and there was a button telling me the week was over, would I not have opened the app, it seems like it would not have notified me.)

When I clicked the "Donate Now & Reset Timer" button, a new button appeared asking for confirmation. I clicked that, but it did not disappear. Nothing happened. So I tried clicking it again, still nothing happened. Then I opened the app full screen and clicked payment history, noticing two identical payments just seconds from each other. They will probably not be confirmed both, since they are double spends, but it is still a bug.

Here's the address: https://blockchain.info/address/1JsXDUXSVNxWeHAAjTXRSqRyi1hpsGBLfQ

stevenroose commented 8 years ago

Well, it seems like they were not double spends, so the amount has been charged twice. This is a severe bug!

Leo-Remitsy commented 8 years ago

Thanks Steven,

I can see where you hit the bug. I'll have to have a look at it on the weekend when I get out of work.

I'll get back on coming weekend. That is soonest I can find some time from work.

-Leo