search

ProTipHQ / ProTip

A browser extension for tipping, donations, and peer-to-peer crowd-funding
https://protip.is
GNU General Public License v3.0
95 stars 15 forks source link

Doesn't seem to pick up on line-broken address' (such as in Twitter bio) #13

Open outragedhuman opened 7 years ago

outragedhuman commented 7 years ago

I've noticed that the app doesn't seem to pick up on Twitter Bio address', and I'm suspecting it's due to the line break. This might be a tricky fix, but Twitter would be one of the biggest places that I would be picking up on addy's so it would be very nice if it could see them.

Example:

image

Leo-ajc commented 7 years ago

Ah yeah, Twitter. Yes, I think it might be the line break. We have had it work on Twitter before, but Twitter is particularly difficult because of all the dynamically loaded content.

If this is not related to the line break, I think it could be related to dynamically loaded content. I was working on attaching a re-search feature on the dynamic loading hook. I remember I had trouble, then I had to take up a new job, which sucked my time away.

I'll see if I can dig up my old branch where I tested out the re-search function.

outragedhuman commented 7 years ago

Sounds good. I'll keep an eye out, if I see an addy without a break in it I'll let you know if it picks up on that one.