search

ProTipHQ / ProTip

A browser extension for tipping, donations, and peer-to-peer crowd-funding
https://protip.is
GNU General Public License v3.0
95 stars 15 forks source link

bitcoin:// Links not always get picked up #4

Closed m0se closed 8 years ago

m0se commented 8 years ago

Maybe this is a issue with validation, I was not able to reproduce that, but I tried running the part of the code that searches for bitcoin:// Links (from content.js line 99-109) in the browser console and the address was found. Only the ProTip icone stays gray and dose not pickup the address.

image

That's the site I had the issue with (german newspaper): http://www.taz.de/Aufweichung-der-Netzneutralitaet/!5246903/

I had this issue several times on other pages to, but that's the first time I looking into it.

Leo-ajc commented 8 years ago

Thanks m0se,

I understand this problem.

ProTip recognises the format. I checked it here.

http://leocampbell.net/protip/protipTest.html

ProTip scans the page when the webpage initially loads. The bitcoin link is dynamically loaded after the page has loaded.

<a href="bitcoin:165dtfwNvyMUbLGdqf87w8DfZX7i542Fyr?label=taz%20zahl%20ich" target="_blank" style="color:#961D2A;">165dtfwNvyMUbLGdqf87w8DfZX7i542Fyr</a>

I need to make ProTip listen to the MutationObserver. https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver

Thanks M0se, I'll be adding it to the next release.