Multiple checkboxes appear beside BTC addresses on ignored site

ProTipHQ / ProTip

A browser extension for tipping, donations, and peer-to-peer crowd-funding

https://protip.is

GNU General Public License v3.0

95 stars 15 forks source link

Multiple checkboxes appear beside BTC addresses on ignored site #9

Open dmnyc opened 8 years ago

dmnyc commented 8 years ago

By default, I have blockchain.info listed as an ignored site, however there are multiple checkboxes appearing beside bitcoin addresses on transaction pages.

Leo-ajc commented 8 years ago

Thanks Dmnyc,

I have had this problem before. I must not have fixed it properly. I recently added a feature that scans HTML which is dynamically loaded after the page has initially loaded.

I think I may have not correctly filtered this.

Let me get into this, I'll get it fixed in the next release.

Cheers

chrisguida commented 8 years ago

This is especially bad on statoshi.info (just move your mouse around on the "Overview" graph):

screen shot 2016-01-19 at 1 39 14 pm

Leo-ajc commented 8 years ago

Hi Chris,

Thanks for the screenshot. I am sorry I haven't had time to fix it yet. I am in the middle doing job interviews. It takes a lot of preparation. I really don't have time to do major fixes. I might revert back to the previous version. It didn't have this issue.

Leo-ajc commented 8 years ago

Hi Chris,

I have disabled to the dynamic loading feature that was causing this bug. I have pushed this change to the Production deployment as v1.0.0.41.

I will only have time to really make these changes when I have a job. At the moment my #1 priority must be getting a paid job, which in turn pay the rent. I am sorry I am just all out of time.

If you have any other bugs, please report them and I'll get on to them as soon as I can.

-Leo