Probe-Particle / ppafm

Classical force field model for simulating atomic force microscopy images.
MIT License
49 stars 18 forks source link

Adding the FePc_Au-IETS example #262

Closed ondrejkrejci closed 7 months ago

ondrejkrejci commented 7 months ago

Fixes #259

Just to have the IETS image in Fig 5 (b) in the examples easily achievable.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6f26011) 46.44% compared to head (14cd5cd) 46.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #262 +/- ## ======================================= Coverage 46.44% 46.44% ======================================= Files 35 35 Lines 5180 5180 ======================================= Hits 2406 2406 Misses 2774 2774 ``` | [Flag](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/262/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `46.45% <ø> (ø)` | | | [python-3.11](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `46.42% <ø> (ø)` | | | [python-3.12](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `46.42% <ø> (ø)` | | | [python-3.7](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `46.25% <ø> (ø)` | | | [python-3.9](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `46.34% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mondracek commented 7 months ago

@ondrejkrejci, the Evib*png and Kvib*png images (examples/FePc_Au-IETS/Evib_atoms_000.png and examples/FePc_Au-IETS/Kvib_atoms_000.png) look virtually identical. Is that to be expected?

ondrejkrejci commented 7 months ago

@ondrejkrejci, the Evib*png and Kvib*png images (examples/FePc_Au-IETS/Evib_atoms_000.png and examples/FePc_Au-IETS/Kvib_atoms_000.png) look virtually identical. Is that to be expected?

Wow, you have tried those. Good job 👍 . At one point, I thought, that the images were uploaded there (which I did not want). Yes, the contrast expected to be the same, but the scale and units are different. Please see: https://github.com/Probe-Particle/ppafm/blob/6f260116f0bb69f871b6c87fb8ad88349d2fbf3f/ppafm/cli/plot_results.py#L158 My guess, that to plot both of those, it is comming to historical reasons (Kvib is the first thing that you want to check) and potentially due to the advanced version of IETS that is comming to https://journals.aps.org/prl/abstract/10.1103/PhysRevLett.119.166001 where we needed the frequency. But to be honnest I do not remember exactly. As the connection to both IETS (in ppafm and ppstm) is pretty complex, I would not change it unless somebody is willing to spend some large time on it. I personally feel that this is not worth of it.

mondracek commented 7 months ago

Wow, you have tried those.

Well @ondrejkrejci , I've got e-mail from GitHub that you explicitly asked me for review, so... You're welcome.

ProkopHapala commented 7 months ago

I personally feel that this is not worth of it.

As the connection to both IETS (in ppafm and ppstm) is pretty complex, I would not change it unless somebody is willing to spend some large time on it. I personally feel that this is not worth of it.

Commentig out saving xsf file is not "pretty complex", if we have clear idea what is better to plot?