Closed ondrejkrejci closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6f26011
) 46.44% compared to head (14cd5cd
) 46.44%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ondrejkrejci, the Evib*png
and Kvib*png
images (examples/FePc_Au-IETS/Evib_atoms_000.png
and examples/FePc_Au-IETS/Kvib_atoms_000.png
) look virtually identical. Is that to be expected?
@ondrejkrejci, the
Evib*png
andKvib*png
images (examples/FePc_Au-IETS/Evib_atoms_000.png
andexamples/FePc_Au-IETS/Kvib_atoms_000.png
) look virtually identical. Is that to be expected?
Wow, you have tried those. Good job 👍 . At one point, I thought, that the images were uploaded there (which I did not want). Yes, the contrast expected to be the same, but the scale and units are different. Please see: https://github.com/Probe-Particle/ppafm/blob/6f260116f0bb69f871b6c87fb8ad88349d2fbf3f/ppafm/cli/plot_results.py#L158 My guess, that to plot both of those, it is comming to historical reasons (Kvib is the first thing that you want to check) and potentially due to the advanced version of IETS that is comming to https://journals.aps.org/prl/abstract/10.1103/PhysRevLett.119.166001 where we needed the frequency. But to be honnest I do not remember exactly. As the connection to both IETS (in ppafm and ppstm) is pretty complex, I would not change it unless somebody is willing to spend some large time on it. I personally feel that this is not worth of it.
Wow, you have tried those.
Well @ondrejkrejci , I've got e-mail from GitHub that you explicitly asked me for review, so... You're welcome.
I personally feel that this is not worth of it.
As the connection to both IETS (in ppafm and ppstm) is pretty complex, I would not change it unless somebody is willing to spend some large time on it. I personally feel that this is not worth of it.
Commentig out saving xsf file is not "pretty complex", if we have clear idea what is better to plot?
Fixes #259
Just to have the IETS image in Fig 5 (b) in the examples easily achievable.