Closed NikoOinonen closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 46.44%. Comparing base (
063cc9a
) to head (90b4550
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ProkopHapala is someone who used and developed this API before, so could maybe offer an expert opinion.
For others (@ondrejkrejci, @mondracek, @yakutovicha) who probably don't know this part of the code could maybe give more of a newcomer's perspective on whether the tutorial makes sense.
Thanks @yakutovicha, I applied the suggestions.
@NikoOinonen - I read it now. I think it is great. Thanks that you did it.
Maybe it would be nice if @mondracek give you some feedback, I remember he was recently trying to run PPAFM on LUNA cluster using OpenCL. @mondracek can you please tell us what problems you had?
Later I would maybe edit some formulations, but currently I don't see any problem content-wise to change. So I recommand to merge it now.
@ProkopHapala
I'm not sure I understood exactly what you wrote here:
- I found a way to write the document in Markdown instead of reST, using the myst-parser extension in sphinx, so this should also work as an example of how to add documentation
- Do I need to instal something or do any other procedures if I want to edit doc/sphinx/source/tutorials/afmulator-tutorial.md ?
By default the sphinx system uses reStructuredText (reST) instead of Markdown, which is what the Github wiki uses. So with this addition it should be easier to just copy-paste material between the wiki and the sphinx docs, if we want to do that.
I recently put some instructions on how the documentation system works in the wiki here: https://github.com/Probe-Particle/ppafm/wiki/For-Developers#sphinx-documentation. Basically there are a couple of additional dependencies for building the HTML pages locally, but editing the document itself does not require anything extra, the web page will get automatically updated once a commit is made to the main branch.
Fixes #268
Added a tutorial to the sphinx docs for how to run GPU-accelerated simulations via the Python API.
I found a way to write the document in Markdown instead of reST, using the
myst-parser
extension in sphinx, so this should also work as an example of how to add documentation if we decide to migrate the wiki content to the sphinx docs like we were briefly discussing previously.A preview of the added page can be seen here: https://ppafm.readthedocs.io/en/api-tutorials/tutorials/afmulator-tutorial.html.