search

Probe-Particle / ppafm

Classical force field model for simulating atomic force microscopy images.
MIT License
49 stars 18 forks source link

MacOS github runner deprecated #288

Open NikoOinonen opened 2 months ago

NikoOinonen commented 2 months ago

The workflow for publishing the PyPI package currently uses the macos-11 runner for making the MacOS build. It looks like this was just recently deprecated: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/. The publishing workflow is now just hanging forever.

There are several replacing runners: macos-12, macos-13, macos-14, and macos-latest. I don't use Mac so I don't know what the differences between the versions are. @yakutovicha I think you were using ppafm on a Mac. Do you have any opinion on this?

NikoOinonen commented 1 month ago

I tested and it seems to build on macos-latest. I cannot test whether the built wheel actually works, so I'll just assume it's fine. I'll make a PR with this.

yakutovicha commented 3 weeks ago

Unfortunately, the build didn't work. The downloaded package didn't contain the '*.so' files.

The latest version of the application that worked for me (Mac, Apple M1 Max chip) is 0.2.2. The installation, however, does the compilation of the code directly on my computer.