search

Probe-Particle / ppafm

Classical force field model for simulating atomic force microscopy images.
MIT License
49 stars 18 forks source link

Fix reading atom_frac from geometry.in #290

Closed mondracek closed 1 month ago

mondracek commented 1 month ago

Fixes #289

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.17%. Comparing base (615c1f8) to head (5445ee7). Report is 7 commits behind head on main.

Files Patch % Lines
ppafm/io.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #290 +/- ## ========================================== - Coverage 50.59% 49.17% -1.42% ========================================== Files 39 37 -2 Lines 5839 5850 +11 ========================================== - Hits 2954 2877 -77 - Misses 2885 2973 +88 ``` | [Flag](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/290/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | Coverage Δ | | |---|---|---| | [python-3.10](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `?` | | | [python-3.11](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `49.14% <0.00%> (-1.42%)` | :arrow_down: | | [python-3.12](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `?` | | | [python-3.7](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `49.01% <0.00%> (-1.41%)` | :arrow_down: | | [python-3.9](https://app.codecov.io/gh/Probe-Particle/ppafm/pull/290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Probe-Particle#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ondrejkrejci commented 1 month ago

@mondracek - Looks good to me. Feel free to Squach and merge