Closed kacper-cyra closed 1 year ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Totals | |
---|---|
Change from base Build 3761812246: | 0.0% |
Covered Lines: | 35 |
Relevant Lines: | 35 |
Additional thing I would suggest is to add Axios to manage connections with the api instead of fetch - axios is much cleaner and readable, but it can be part of the other issue
Parsing error: No Babel config file detected for /Applications/Programy/Goodmap-Kacper/goodmap-frontend/src/components/MarkerPopup/MarkerPopup.test.jsx. Either disable config file checking with requireConfigFile: false, or configure Babel so that it can find the config files.eslint
Im not sure I'm only one who got this issue, but maybe I miss sth. General solution is working, but I receive this eslint issue in every file.
I recommend opening and testing the app locally as it's big refactor. Feel free to add propositions to the repo as it's still fresh 😄 I have left a big chunk of map as it is, because we can't use react-leaflet yet, as we are limited to one React root, and as for now filters and map are in two separate places in HTML document and filters form is treated as the root, and a map is handled outside of React. After we discuss if and how we will handle it we will make separate task for it.
Most of commits is from previous PR as this one derived from it
Closes #18