coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 4009523646
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 18 (0.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-10.3%) to 48.039%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/components/Map/components/LocationControl/LocationControl.jsx | 0 | 18 | 0.0% | ||
| <!-- | Total: | 0 | 18 | 0.0% | --> |
| Totals | |
|---|---|
| Change from base Build 3995591653: | -10.3% |
| Covered Lines: | 35 |
| Relevant Lines: | 88 |
raven-wing
Davcode1234
There is no unit test for this component as it is fully dependent on Leaflet and browser geolocation API, and because of this there would be plenty of mocking and this case suit would be pretty useless. My proposition is to cover this in suit of e2e or integration test for whole map component.
There was mention of problem with Mozilla Firefox not saving permission on locating user. On macOS I could not reproduce. After selecting remember decision I did not get a popup on new enter.
closes #23