search

ProctorU / squint

Search PostgreSQL jsonb and hstore columns
MIT License
26 stars 3 forks source link

Rails 5.x support #12

Closed dwilkins closed 7 years ago

dwilkins commented 7 years ago

Squint needs to support Rails 5

dwilkins commented 7 years ago

I briefly investigated this:

  1. build_where is gone. Overridding where used to kill the ability to participate in WhereChain therefore killing .not capability. IDK if overriding where in 5.x will work or suffer similar issues.
  2. hash_field_reln returns an element, not an array like super does. I forget why that is, and it may need to change. This return behavior may be a hold-over from my original attempt to override where.
  3. Rails 5.x introduces WhereClauseFactory and WhereClause which appear to be what this feature might use. WhereClauseFactory and WhereClause appear to have some significant updates in 5.1 as well.