Review master end - Githubissues

ProctorU / squint

Search PostgreSQL jsonb and hstore columns

MIT License

26 stars 3 forks source link

Review master end #2

Closed dwilkins closed 7 years ago

dwilkins commented 7 years ago

Mock PR for review by the team. (There was a previous PR like this one deleted)

Please review w/r/t:

Release as Open Source
Suitability for our purposes
Code readability

bitmoji

/cc @licatajustin @onesneakymofo @king601 @chevinbrown @kmiracle86 @Jaehdawg @TheJayWright @BryanSaxon @iheartcharts

dwilkins commented 7 years ago

Thanks @king601 for fixing the PR

licatajustin commented 7 years ago

I haven't gone through technically, but I'd like to get rubocop run through here (with the Archimedes config) before we make this public.

dwilkins commented 7 years ago

Thanks reviewers - I'm gonna cherry pick these changes into master this evening. Make sure you request changes on this PR if my revisions were not sufficient.

dwilkins commented 7 years ago

Close - all changes merged to master