search

Procurement-PoE / Procurement

Path Of Exile Character & Stash Management Tool
Artistic License 2.0
331 stars 133 forks source link

Character inventory bug #1030

Closed nqrcqn closed 5 years ago

nqrcqn commented 5 years ago

I think this problem started happening after the new league, happens on both 1.27.1 and 1.26.1 whereas it didn't happen on 1.26.1 before Legion.

image

Each character inventory looks like this now and clicking on it crashes Procurement

debug.txt

thailyn commented 5 years ago

Are your Standard / HC Standard stashes working properly? Did you delete any characters? I'm not able to recreate this with my own data. Would you be able to zip and upload your .bin files, so I can examine it with your data? They're located in the directory named after your account named used when logging in.

You can also try enabling the "Refresh on Login" button on the Procurement login screen. That should get a fresh copy of all of your data from GGG. My guess is there could be some data corruption or missing data that Procurement is looking for.

nqrcqn commented 5 years ago

All non-character stashes work properly, but all of my characters on standard etc. have the same issue now for some time. I delete characters sometimes. And "Refresh on Login" is always on.

thailyn commented 5 years ago

I'm able to load your bin files in offline mode without an issue, though -- and of course I forgot this nuance earlier -- I can't test refreshing. The logging information in the debug file is also unfortunately pretty poor. There's definitely an issue going on somewhere, as you're at least failing to download the images for the tab selector (since they show up as X's).

I added some additional logging in the draft PR #1033 that will hopefully point us in the right direction. Could you try out that version and provide the DebugInfo.log file after you get errors/crashes? Thanks!

nqrcqn commented 5 years ago

I replaced my char name in log with *charname*

debug.txt

Both of the crashes seem to be caused by that 404 error.

thailyn commented 5 years ago

Thanks for your patience and for the additional debugging log. I believe I've figured out the cause of the crash. I've updated PR #1033 with additional logic to handle this case. I haven't figured out yet why the tab image URLs are wrong and thus show up as X's, but this fix should prevent Procurement from crashing.

nqrcqn commented 5 years ago

Thanks, crashes from clicking on inventory, after refreshing, or after excluding a tab from recipe results are all fixed now

thailyn commented 5 years ago

Thanks for the confirmation! I'll clean up the PR and request for it to be merged soon.

nqrcqn commented 5 years ago

Off topic, Procurement seems to be using http instead of https for webcdn.pathofexile.com and www.pathofexile.com in some cases. Can we replace those just in case, though it likely doesn't fix my issue, it can be a problem regardless.

nqrcqn commented 5 years ago

And apparently those image links are hardcoded inside CharacterTabInjector.cs and they no longer exist there. Why not use an offline copy of those instead of downloading them? I have a copy of them here from a Procurement folder that I used before Legion (renamed them):

Stash_Tab.zip

nqrcqn commented 5 years ago

Indeed simplest fix for now is just copying them inside the Common folder with their original names as I found them:

stashtab.zip

The Xs disappeared and the old look is back. I'm guessing those that aren't able to reproduce this issue already have these files inside their Procurement folder and not testing on a fresh one.