ProcursusTeam / Procursus

Modern *OS Bootstrap
https://apt.procurs.us
BSD Zero Clause License
861 stars 126 forks source link

Make shshd non-essential #1254

Closed L1ghtmann closed 2 years ago

L1ghtmann commented 2 years ago

All Submissions

Package Additions/Updates

Preface

I believe I changed all of the relevant lines, but apologies in advance if I missed something.

Thoughts

Despite shshd being an extremely useful package, I don't believe it should be marked as essential and installed with the strap.

Most users likely don't care for or know what blobs are, so it makes very little sense to have a daemon uploading blobs for their device to a (trusted) 3rd party server without their knowledge or consent. If they know what blobs are and wish to save them, they'll see the value of this package and install it themselves...there's no need to do it for them.

Moreover, marking it as essential and making it a dependency of the essential meta package (i.e., preventing it from being removed) is somewhat of an odd choice. Its purpose is not integral to the system and it cannot be easily disabled by a regular user (terminal = scary and launchctl = ??).

NSAntoine commented 2 years ago

Most users likely don't care for or know what blobs are, so it makes very little sense to have a daemon uploading blobs for their device to a (trusted) 3rd party server without their knowledge or consent

While I agree the user consent part is a bit questionable, I do think it's very useful for users to have blobs either way, as, later, they may gain understanding of them, and in certain cases, the blobs uploaded by shshd may have saved them from losing their jb

CRKatri commented 2 years ago

I agree we should remove it from essential, but keep it in the bootstrap. I'll merge this after you make those changes.

L1ghtmann commented 2 years ago

@CRKatri Done. Appreciate your consideration! This seems like a good comprise.