search

ProdPerfect / prodperfect-keen-tracking.js

Keen IO Streams SDK - record events from anywhere in your stack
https://keen.io/products/streams/
MIT License
3 stars 4 forks source link

Hotfix for metadata circular reference issue. #42

Closed adewinter closed 5 years ago

adewinter commented 5 years ago

Switched to using 'safer' .getAttribute style.

adewinter commented 5 years ago

@Detect not sure, if we want to get this out soonish I'd vote no (though I would like to add tests for this case at a later juncture)

Detect commented 5 years ago

@adewinter can you confirm the CI output is good (some errors even tho it passes)?

adewinter commented 5 years ago

@Detect I think those are unrelated to this issue, but I'll double check to verify they also show up in old builds

adewinter commented 5 years ago

Yep, unrelated/old warnings.