[HR] refactoring hacks

[PatheticMustan]

basically just delete hacks and rewrite, hopefully won't be too hard

pls don't comment on this issue, I'm just going to use it to reference in commits

[00100000]

You assigned this to yourself a while ago, and I'm not sure if you referenced this in commits. I don't know much about prodigy as a game, but I'm not too terrible with js and it's hacktoberfest, so, any particular hacks in mind you'd want refactored? I wouldn't mind getting prodigy to make sure my refactors don't break anything.

[PatheticMustan]

number one would be investigating why some hacks return http 418, while others do not. this seems to be a recent change, and affects almost half of our hacks (???), or at least the imporant ones.

iiuc hacks are still possible, but the line between triggering 418 and not seems very very vague, it would be nice to get a better idea of why

[00100000]

Does it only sometimes return a 418? It'd be very annoying and hard to find out why, because I saw that another user reported that it wouldn't return 418 if they did something with popups.

[PatheticMustan]

no, it's consistent. Get All XYZ usually triggers it

[00100000]

I have no idea what that means :P

[ArcerionDev]

I have no idea what that means :P

get all [blank] (method of obtaining items)

xyz is a placeholder

[00100000]

X is better placeholder!

[ghost]

no, it's consistent. Get All XYZ usually triggers it

its possible that when you obtain a shit ton of things at once that it fucks stuff up and stuff

[afkvido]

[proceeds to comment on issue]

Mustan: 😡

[PatheticMustan]

i only get annoyed when people make unrelated comments for no reason...?? You could just ask if there are any updates

[afkvido]

Oh, ok.

So, how's refactoring the hacks going?

[afkvido]

This is still pinned btw @PatheticMustan