Prodigy-Hacking / ProdigyMathGameHacking

Prodigy Hacking: Hacking for the right reasons. | Questions? Ask on our Discord. https://discord.gg/XQDfbfq
https://prodigyhacking.com
Other
17 stars 10 forks source link

maybe fix skids from asking about developer options? #1257

Closed afkvido closed 2 years ago

afkvido commented 2 years ago

edit: I build this in #1285

Description

maybe fix skids from asking about developer options?

changing the phex popup also, please for the love of god someone webpack this for me if that's needed, i'm too retarded to do that myself

Screenshots

image

00100000 commented 2 years ago

The UI seems pretty clear to me, honestly. Your thoughts @PatheticMustan?

afkvido commented 2 years ago

The UI seems pretty clear to me, honestly. Your thoughts @PatheticMustan?

YAAAAAY I DON'T HAVE TO WEBPACK LETS GOOOOOO

00100000 commented 2 years ago

The UI seems pretty clear to me, honestly. Your thoughts @PatheticMustan?

YAAAAAY I DON'T HAVE TO WEBPACK LETS GOOOOOO

That's not what I said :P

PatheticMustan commented 2 years ago

LGTM

ArcerionDev commented 2 years ago

ya still have to build the extension

PatheticMustan commented 2 years ago

For future reference I'm pretty sure there's a build.js script you can just run.

ArcerionDev commented 2 years ago

you need to install some deps, not sure if kozel knows how to do that

00100000 commented 2 years ago

@PatheticMustan why didn't you bundle the changes???

ArcerionDev commented 2 years ago

@PatheticMustan why didn't you bundle the changes???

image

00100000 commented 2 years ago

messy way to do things imo cuz now bundling will be in a separate commit instead of squashed with this.

afkvido commented 2 years ago

you need to install some deps, not sure if kozel knows how to do that

i tried npm install, still couldnt build/pack

im bad with npm

afkvido commented 2 years ago

messy way to do things imo cuz now bundling will be in a separate commit instead of squashed with this.

yes, its a very messy way to do it. but i am dum dum

00100000 commented 2 years ago

No, I was talking about Mustan merging without building the extension, so he'll need to create another commit where he builds it.

afkvido commented 2 years ago

No, I was talking about Mustan merging without building the extension, so he'll need to create another commit where he builds it.

ik