search

Prodigy-Hacking / ProdigyMathGameHacking

Prodigy Hacking: Hacking for the right reasons. | Questions? Ask on our Discord. https://discord.gg/XQDfbfq
https://prodigyhacking.com
Other
17 stars 10 forks source link

rename Easy Mode to Disable Math #1294

Closed afkvido closed 2 years ago

afkvido commented 2 years ago

Description

rename Easy Mode to Disable Math

I ACTUALLY BUNDLED THIS

Screenshots

rename Easy Mode to Disable Math

afkvido commented 2 years ago

I ACTUALLY BUNDLED THIS, ARE Y'ALL PROUD OF ME

00100000 commented 2 years ago

I ACTUALLY BUNDLED THIS, ARE Y'ALL PROUD OF ME

lol yes im very proud

ArcerionDev commented 2 years ago

what could go wrong

00100000 commented 2 years ago

what could go wrong

I guess inconsequential commits are fine as long as we can actually trust the author not to break the code, but I still think since we pretty much deploy everything on master branch live, we should by default close any small PRs like this that don't offer much contribution, because they're not worth bundling and testing, which we absolutely should do for all PRs. Theoretically, any attacker can just put any malicious code they want in the bundle, make an inconsequential change to the code, and hope we don't test it, which we don't! This isn't good practice for security.

ArcerionDev commented 2 years ago

that's a good point actually, I thoughtlessly merged this one cus I trust gemsvido but I'll keep that in mind itf

00100000 commented 2 years ago

Not merging tiny commits isn't only to discourage unimportant contributions, it's something we should seriously consider doing because it could cause major security issues.

ArcerionDev commented 2 years ago

yeah I understand what you mean

afkvido commented 2 years ago

;) YESSSSS, FINALLY I MANAGED TO MAKE A SUCCESSFUL PR

THIS IS MY HAPPIEST DAY ON THIS REPO

00100000 commented 2 years ago

I will be happy when I make a meaningful contribution.

00100000 commented 2 years ago

My PRs are sorta bad too lmao.

afkvido commented 2 years ago

I will be happy when I make a meaningful contribution.

;) youre a collaborator

00100000 commented 2 years ago

Only because I know Natsumi irl and he knows I am somewhat competent at coding.

afkvido commented 2 years ago

lmao

afkvido commented 2 years ago

I'm ngl, the main purpose of this PR was to see if I could bundle it correctly.

yay, I could :)

00100000 commented 2 years ago

I'm ngl, the main purpose of this PR was to see if I could bundle it correctly.

yay, I could :)

Then don't make a PR...

afkvido commented 2 years ago

I'm ngl, the main purpose of this PR was to see if I could bundle it correctly. yay, I could :)

Then don't make a PR...

my contribution was actually helpful tbh.... "Easy Mode" isn't actually very descriptive.

00100000 commented 2 years ago

A drop in the ocean.

afkvido commented 2 years ago

;)