Open ProditorMagnus opened 1 year ago
RE - all reported in forum, considering solved
I tried schema validation. These cases seemed more important and should be tested if they work.
20230713 19:24:11 error validation: Extra tag [filter]; there may only be 1 [filter] in [event] at ~add-ons/Ageless_Era/data/RE_data/condition_blur.cfg:57 20230713 19:24:11 error validation: Extra tag [filter_second]; there may only be 1 [filter_second] in [event] at ~add-ons/Ageless_Era/data/RE_data/condition_blur.cfg:21
20230713 19:24:11 error validation: Invalid key 'movement_type=' in tag [filter] at ~add-ons/Ageless_Era/data/RE_data/abilities-leadership.cfg:60 20230713 19:25:15 error validation: Invalid key 'side=' in tag [store_unit] at ~add-ons/Ageless_Era/data/RE_data/abilities_mount.cfg:20 20230713 19:24:10 error validation: Invalid key 'time=' in tag [effect] at ~add-ons/Ageless_Era/data/RE_data/traits.cfg:334 20230713 19:25:15 error validation: Tag [chance_to_hit] may not be used in [attack] at ~add-ons/Ageless_Era/data/RE_data/specials-accuracy.cfg:23 included from ~add-ons/Ageless_Era/_main.cfg:67 included from ~add-ons/Ageless_Era/data/_main.cfg:21 included from ~add-ons/Ageless_Era/_main.cfg:91 included from ~add-ons/Ageless_Era/units/RE_units/human-luz/Angel_archer.cfg:39
20230713 19:25:15 error validation: Tag [event] may not be used in [effect] Event based abilities cant go to effect. I believe it is not ageless-specific bug. Stacktrace is misleading so did not include it, but look amla.cfg
20230713 19:25:16 error validation: Tag [filter] may not be used in [remove_object] at ~add-ons/Ageless_Era/data/RE_data/condition_drugged.cfg:43
Core bugs as of 1.16 schema
Invalid key 'upkeep=' in tag [unit_type] Invalid key 'path=' in tag [textdomain]
20230713 19:23:49 error validation: Invalid value '$drone.attack[0].damage' in key 'damage=' in tag [effect] (expected value of type int) at ~add-ons/Ageless_Era/data/EoMa_data/drone-upgrades.cfg:70 20230713 19:23:49 error validation: Invalid value '$second_unit.facing' in key 'adjacent=' in tag [filter_adjacent_location] (expected value of type dir_list) at ~add-ons/Ageless_Era/data/EoMa_data/beam.cfg:101 20230713 19:23:49 error validation: Invalid value '$second_unit.alignment' in key 'alignment=' in tag [harm_unit] (expected value of type alignment) at ~add-ons/Ageless_Era/data/EoMa_data/cleave.cfg:80 20230713 19:25:14 error validation: Invalid value '-$knockback_direction' in key 'adjacent=' in tag [filter_adjacent_location] (expected value of type dir_list) at ~add-ons/Ageless_Era/data/SH_data/weapon_specials/knockback.cfg:133
Invalid key 'active_on=' in tag [*] [dummy] weapon special Invalid key 'apply_to=' in tag [*] probably should review all the common keys and tags allowed in all abilities or specials
error validation: Invalid key 'min=' in tag [set_variable] Invalid key 'mode=' in tag [store_locations]
Test if works, then decide whether to change or edit schema
error validation: Extra tag [filter]; there may only be 1 [filter] in [event] example in steelhive knockback
EoMa - events handled by creating unit that has them during prestart solved
20230713 19:23:17 error validation: Tag [event] may not be used in [effect] at ~add-ons/Ageless_Era/data/EoMa_data/abilities.cfg:1337 included from ~add-ons/Ageless_Era/_main.cfg:67 included from ~add-ons/Ageless_Era/data/_main.cfg:11 included from ~add-ons/Ageless_Era/_main.cfg:91 included from ~add-ons/Ageless_Era/units/EoMa_units/Dark_Blood_Alliance/Desert_Salamander.cfg:52 20230713 19:23:49 error validation: Tag [event] may not be used in [effect] at ~add-ons/Ageless_Era/data/EoMa_data/abilities.cfg:44 included from ~add-ons/Ageless_Era/_main.cfg:67 included from ~add-ons/Ageless_Era/data/_main.cfg:11 included from ~add-ons/Ageless_Era/_main.cfg:91 included from ~add-ons/Ageless_Era/units/EoMa_units/Runemasters/Drone.cfg:53 20230713 19:23:50 error validation: Tag [event] may not be used in [effect] at ~add-ons/Ageless_Era/data/EoMa_data/pain_absorption.cfg:218 included from ~add-ons/Ageless_Era/_main.cfg:67 included from ~add-ons/Ageless_Era/data/_main.cfg:11 included from ~add-ons/Ageless_Era/_main.cfg:91 included from ~add-ons/Ageless_Era/units/EoMa_units/Tharis/Chainlady.cfg:24 20230713 19:25:10 error validation: Tag [filter_weapon] may not be used in [chance_to_hit] at ~add-ons/Ageless_Era/data/EoMa_data/chronoaura.cfg:27 20230713 19:23:50 error validation: Tag [movetype] may not be used in [unit_type] at ~add-ons/Ageless_Era/units/EoMa_units/Tharis/Great_Warlock.cfg:78
I'm pretty sure it's true that there can be only one filter of each type in an event. If you add an extra it will be ignored, I believe.
https://github.com/wesnoth/wesnoth/blob/master/data/schema/units/types.cfg Some need to be fixed, should rerun with master. wesnoth --validate-addon Ageless_Era