respect is_immune_to_specials unit variable for certain abilities and specials

[andrzejskutela]

hi as we spoke before here's the list of abilities and specials to be considered

abilities that are definitely too op: no-counter-attack, deadly strike, scultps, stone grip, vector

abilities that are to be debated: mind fog, hex, decay, amputation, awe, dazzle, circle of susceptibility, crimson aura, weakening aura, terror, charm, soothing, fear (rashy), dread (eoma), dread (ae / general), dread (ele)

what I already use in uws is is_immune_to_specials=yes variable on units and then in various events I filter by for example

[filter_second]
    [not]
        [filter_wml]
            [variables]
                is_immune_to_specials=yes
            [/variables]
        [/filter_wml]
    [/not]
[/filter_second]

so my proposition is to add something similar to AE

[ProditorMagnus]

Not planning to add more for this release. Would be good if you tested the conditions work correctly.

[andrzejskutela]

stone grip works for sure, I didn't test the others tested against two units, one with the variable set and one without - worked as expected in both cases

as mentioned in the wesnoth chat though, I will in the relatively near future deprecate the use of this variable and instead filter by a trait. I haven't decided on the trait id yet so I'm open to suggestions, but if none given I will probably settle on something like qquws_is_champion to maintain the pseudo-namespace.

[ProditorMagnus]

If it has prefix I wont check for it from ageless.

[andrzejskutela]

so let's agree on something, at the end of the day nothing stops me from having two traits immune_to_specials?

[ProditorMagnus]

@Ravana I dropped the support for is_immune_to_specials variable in favour of id=immune_to_specials trait

[ProditorMagnus]

For EoMa cases you want, I expect you get approval from inferno8 and then I would commit changes there.