Add the `lstautogobble` package - Githubissues

ProdriveTechnologies / bazel-latex

Bazel build system rules for LaTeX

Apache License 2.0

75 stars 37 forks source link

Add the `lstautogobble` package #108

Closed PHPirates closed 1 year ago

PHPirates commented 1 year ago

I haven't managed to verify if the patch is correct, so please check.

I do want to note that after adding patches = ["lstautogobble.patch"] to WORKSPACE, you need to put the patch in the external directory apparently. However, then it complains Cannot find file to patch (near line 3), old file name (a/packages/BUILD.bazel) doesn't exist. Is the readme up to date?
Build failure does not seem caused by this PR: Server terminated abruptly (error code: 14, error message: 'Socket closed'

solsjo commented 1 year ago

Hi @PHPirates,

I didn't find your patch as part of the pull-request. But I did apply your changes on-top of master, and it seems you then need to add the target ":listings", to your filegroup, like so:

latex_package( name = "lstautogobble", srcs = [ "@texlive_texmftexmf-disttexlatexlstaddons",

":listings", ], tests = ["lstautogobble_test.tex"], )

That made it pass locally on my machine, try that out.

solsjo commented 1 year ago

The buildifier check fails. Fix it and we'll be able to take it in

solsjo commented 1 year ago

@PHPirates

solsjo commented 1 year ago

I assume it is the lexical order of the srcs

PHPirates commented 1 year ago

@solsjo I don't know, it's a weird linter that it doesn't say what's wrong. I did my best guess but can't run the build to check.

solsjo commented 1 year ago

@PHPirates , yes that's unfortunate and annoying...

In any case, you solved it!

Merge incoming!