ProdriveTechnologies / bazel-latex

Bazel build system rules for LaTeX
Apache License 2.0
75 stars 37 forks source link

Support visibility parameter on latex_document macro #70

Closed kleinpa closed 1 year ago

kleinpa commented 2 years ago

This will let me incorporate latex documentation in a pkg_tar() rule from a different directory.

This style of visibility pass-through is used throughout https://bazel.build/rules/macros.

Kernald commented 2 years ago

Should we simply pass **kwargs instead, and remove the existing tags as well? I'm not too sure about what the correct approach is here. There's quite a few common attributes that should be allowed.

solsjo commented 1 year ago

Support for visibility was added in PR-87 .

Does that cover your needs @kleinpa? If so, perhaps we can close this PR?