search

ProductiveRage / Bridge.React

Bindings for Bridge.NET for React - write React applications in C#!
MIT License
74 stars 14 forks source link

InputAttributes.Autocomplete does not accept strings #31

Closed DanTup closed 7 years ago

DanTup commented 7 years ago

(Raised a similar issue in Bridge at https://github.com/bridgedotnet/Bridge/issues/2970)

Currently the AutoComplete property on input attributes only accepts an enum with a value of On or Off, however it's valid to have arbitrary strings and also a set of defined ones (like new-password and address-line1, etc.):

https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill-detail-tokens

Should this be Union<string, AutoComplete>?

ProductiveRage commented 7 years ago

Makes sense. I see that Bridge have already made the change on their end!