search

ProductiveRage / Bridge.React

Bindings for Bridge.NET for React - write React applications in C#!
MIT License
74 stars 14 forks source link

Change attributes to have non private getters #58

Closed kendallb closed 5 years ago

kendallb commented 5 years ago

Referencing issue #57, if attributes have private getters it is not possible to read the value from the attributes at all. Normally these would only be passed to the React components, but if you are building extension components you may need to read those values to modify them into a cloned properties structure before passing it to the real component (such as adding in a class name).

kendallb commented 5 years ago

I just realized this also has my changes for aria- stuff in it as well. Should I re-base this one off master prior to those changes, or is it fine to leave it this way?

ProductiveRage commented 5 years ago

This should be fine to merge, I will review over the next few days to double-check. Don't worry about rebasing, the other PR also looks good.

ProductiveRage commented 5 years ago

I think that my original justification for this was as you suspect: "Normally these would only be passed to the React components" (and so there wouldn't ordinarily be a case for Bridge code to mess about with / inspect the value). But I agree that "if you are building extension components you may need to read those values to modify them into a cloned properties structure before passing it to the real component (such as adding in a class name)" - so I'm happy to merge.

ProductiveRage commented 5 years ago

Released in v5.1.0, which nuget.org is indexing at the moment.

kendallb commented 5 years ago

Awesome thanks!

Regards,

Sent from my iPad Air!

Kendall Bennett CEO & Co-Founder www.AMain.comhttp://www.amain.com/ | 530-894-0797 | 800-705-2215 424 Otterson Drive, Chico, California 95928<x-apple-data-detectors://2/1>

On Feb 2, 2019, at 5:38 PM, ProductiveRage notifications@github.com<mailto:notifications@github.com> wrote:

Released in v5.1.0, which nuget.orghttp://nuget.org is indexing at the moment.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ProductiveRage/Bridge.React/pull/58#issuecomment-460014984, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAgtEZOeX5fVvu-TGSfbKh0x3W1a8b7Aks5vJj2sgaJpZM4acy8c.