search

Prof-Butts / Hook_XWACockpitLook

X-Wing Alliance mouse hook with support for VR head-tracking
6 stars 1 forks source link

Extract local/user specific config into props file and add .gitignore. #3

Closed morallo closed 3 years ago

morallo commented 3 years ago

Merge UDP back into master, to keep master as the latest one, and Tags/Branches for stable releases.

Remove the local customizations from the .vcxproj and moving them to a .props file that can be maintained out of git control. This way it's easier to merge upstream changes without having to fix the build locally every time.

The first time that this change is applied or when you clone the repo, a LocalProperties.prop file needs to be created with the Include/Library paths and the PostBuild command if desired.

I have added the previous values to LocalProperties.prop.default so that @Prof-Butts only needs to copy and rename the file.

I also added a .gitignore for convenience.

Prof-Butts commented 3 years ago

Hello @morallo!

Please, help me understand something: why are there so many commits in this pull request? Is it because you're doing it against the master branch? Shouldn't we do a PR against the UDP branch first? Then I can do a PR from UDP to master and then we can continue working on the master branch.

Also, other than the .gitignore and .props files, are there any changes in the code?

morallo commented 3 years ago

I did all at once:

  1. Merge UDP into master
  2. Do the project config changes

No other changes in the code. You can compare my PR with UDP branch, or I can change the PR target to UDP and do it in 2 steps.

morallo commented 3 years ago

PR updated to the new HEAD of master