search

Prof-Butts / xwa_ddraw_d3d11

Direct3D 11 implementation of DDraw.dll for XWA with VR support and New Shaders
MIT License
6 stars 4 forks source link

Some new XWAU2024 reticles not displayed in VR #105

Open morallo opened 1 month ago

morallo commented 1 month ago

Multiple reports: https://forums.xwaupgrade.com/viewtopic.php?t=14390#p193535 https://forums.xwaupgrade.com/viewtopic.php?t=14389

https://discord.com/channels/851918539496620062/1104824817519181878/1261477319005048906 https://discord.com/channels/851918539496620062/1104824817519181878/1261583875449032744

It seems the impacted ships are: The X-Wing has no laser sight, but does have a missile sight The Y-Wing has no laser sight, and no missile sight, but missile ammo counts do appear floating above the dash when switched to missiles. The B-Wing Fighter didn't have an aiming reticle for lasers/ions. It did for torpedoes, thankfully.

According to Ace, the reticles were probably updated in XWAU2024_beta3.

changes are to Y-wing, B-wing, Z-95 and X-wing I believe. Some partially, the Y-wing completely They had new laser or missile sights. Or adjustments to exciting. So they used new dat numbers

@Prof-Butts can you document here your findings? I will try to debug on my side and it will make coordination in different timezones easier 😄

morallo commented 1 month ago

It seems this function is actually the culprit: https://github.com/Prof-Butts/xwa_ddraw_d3d11/blob/master/impl11/ddraw/Reticle.cpp#L56

Instead of that "stupid numbering system" 😄 it should be just iterating the DatFile and retrieving the metadata for the element in the position/slot/index specified by <FlightModel>.ini

The question is, should it be implemented in JeremyAnsel.Xwa.Dat or in DATReader?