search

Prof-Lu-Cewu / Visual-Relationship-Detection

Other
214 stars 60 forks source link

Misusing MATLAB function "length" #2

Closed renmengye closed 8 years ago

renmengye commented 8 years ago

Hi,

Thanks you for the effort of releasing the source code. In top_recall_Relationship.m, when calculating num_pos_tuple, you used length(gt_tuple_label{ii}). length gives the dimension of the longer axis, which results in an erroneous denominator when calculating recall score. Would you consider fix and use size(gt_tuple_label{ii}, 1) instead?

Prof-Lu-Cewu commented 8 years ago

thanks Mengye Ren

you are right, I found the my result have slight improvement,

I will revise it soon.

发件人: Mengye Ren notifications@github.com 发送时间: 2016年8月17日 22:04 收件人: Prof-Lu-Cewu/Visual-Relationship-Detection 主题: [Prof-Lu-Cewu/Visual-Relationship-Detection] Misusing MATLAB function "length" (#2)

Hi,

Thanks you for the effort of releasing the source code. In top_recall_Relationship.m, when calculating num_pos_tuple, you used length(gt_tuple_label{ii}). length gives the dimension of the longer axis, which results in an erroneous denominator when calculating recall score. Would you consider fix and use size(gt_tuple_label{ii}, 1) instead?

― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Prof-Lu-Cewu/Visual-Relationship-Detection/issues/2, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATVciXDUalbaqJvJ6K5_ErNAE7FFqibNks5qgxUCgaJpZM4JmfAK.

renmengye commented 8 years ago

Thanks for the reply. Just a reminder that a same fix will apply to top_recall_Phrase.m.

Prof-Lu-Cewu commented 8 years ago

have fixed

发件人: Mengye Ren notifications@github.com 发送时间: 2016年8月18日 2:34 收件人: Prof-Lu-Cewu/Visual-Relationship-Detection 抄送: Prof-Lu-Cewu; Comment 主题: Re: [Prof-Lu-Cewu/Visual-Relationship-Detection] Misusing MATLAB function "length" (#2)

Thanks for the reply. Just a reminder that a same fix will apply to top_recall_Phrase.m.

― You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Prof-Lu-Cewu/Visual-Relationship-Detection/issues/2#issuecomment-240505286, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATVciRcyHJj6eUglueZQlj_zzed9daZlks5qg1Q_gaJpZM4JmfAK.